topogram icon indicating copy to clipboard operation
topogram copied to clipboard

Comment Example Doesn't Have Correct Number of Variables

Open emeeks opened this issue 10 years ago • 6 comments

In the commented out example of how to use the code it only refers to topology (and not also the geometry) variable:

  • var features = cartogram(topology);

emeeks avatar Sep 05 '14 18:09 emeeks

@emeeks Are you working on this? I have been working on an adaptation for rCharts. I discovered quickly that it is based on a very old version of topojson. I made some quick changes here to use version 1 of topojson, but this requires some slight changes to the code. I believe it could be easily fixed to drop in with no required changes.

timelyportfolio avatar Sep 05 '14 18:09 timelyportfolio

Hi guys, pull requests are much appreciated. I'm taking care of a newborn right now and don't have solid stretches of time to fix these issues. Thanks for looking out!

shawnbot avatar Sep 05 '14 19:09 shawnbot

@timelyportfolio are you interested in submitting a pull request with your TopoJSON update?

shawnbot avatar Jul 20 '15 16:07 shawnbot

honestly forgotten what I did, but will plan to dig up. Examples from that experiment.

http://timelyportfolio.github.io/rCharts_cartogram/world_usopen_mayer.html http://timelyportfolio.github.io/rCharts_cartogram/world_usopen.html

timelyportfolio avatar Aug 01 '15 01:08 timelyportfolio

@shawnbot I should be able to work on it this week

timelyportfolio avatar Sep 14 '15 10:09 timelyportfolio

I have a working version with example using topojson 1.6.19. Let me know if you deem pull-requestable.

timelyportfolio avatar Sep 14 '15 12:09 timelyportfolio