itunes-data icon indicating copy to clipboard operation
itunes-data copied to clipboard

parser does not emit either album or artist

Open MasterOdin opened this issue 9 years ago • 1 comments

So in using your library (thanks for writing it!), I noticed that the parser doesn't in fact output either of those two types, just track, library, and playlists, and figured it'd be a neat way to contribute back if possible.

I'm assuming that for artist you'd want:

{
  "Artist": "Test",
  "Track Count": 5,
  "Play Count": 10
}

where artist is Album || Artist Album and then the track count is just the number of entries in tracks for the artist and play count is using Play Count in each track field.

Album:

{
  "Artist": "Test",
  "Album": "Test Album",
  "Tracks": [ ... ],
}

where then each item in that Tracks item is a track object from the tracks stream? Or something else?

I think we could stream the albums as we encounter the end of them as the file does have all albums grouped together (so just track the album name, and if the next track has a different album, then we have reached the end of the album), but artists would have to be outputted after the first library has finished parsing (the non playlist one).

MasterOdin avatar Nov 01 '16 22:11 MasterOdin

@MasterOdin I see, that your PR #3 was about changning proper event name. And PR is closed. It was due to documentation mismatch? Right? Or issue u described still remain?

If no objections from above, maybe @shawnbot we can close this issue?

alundiak avatar Feb 20 '17 01:02 alundiak