Shawn Borton

Results 171 comments of Shawn Borton

Personally I think it looks great! On Mon, Dec 5, 2022 at 7:31 PM Luke Donahue ***@***.***> wrote: > @shawnborton , when testing this I came > across this difference...

How did you fix the bottom portion of the text from being cut off? Maybe you need to push your code? I don't see anything that explains how it was...

On Android it looks like the input value is not lined up with the left edge like the label is: Also, are we planning to have a C+ do a...

I think we should have a C+ do a thorough review. From the previous PRs for the branding changes, we've had to do quite a few follow up PRs for...

I think this might be a result of removing the line height? But 52px is what we had previously, so ideally we have the same height with this new change.

> IMO, we should reduce the right padding from the arrow. @shawnborton Agree with that

> Web: Slight dimensions change to the left-sidebar on the login page. Are we sure that's related to this PR?

I agree that it is a problem - the inputs should all appear to be the same height no matter if its a text input or a select menu or...

I agree, the emoji suggestion box does not need to be reduced opacity here. cc @trjExpensify @JmillsExpensify my favorite offline pattern experts