Shawn Borton

Results 171 comments of Shawn Borton

That feels pretty good to me. Can you show us the verified state too? Also, cc @JmillsExpensify @jamesdeanexpensify but we should get crisp on when a violation/note has a period...

It looks like we use two different kinds of little dot separators for Receipt and Amount - why is that? I would think that they would be the same right?...

I am a bit confused here, what is the subscription icon? In your video though, why are you changing the border color of the small button over the workspace icon?...

Also, it looks like something changed with the border color too? The button should have a border around it like this: ![CleanShot 2024-02-05 at 09 19 29@2x](https://github.com/Expensify/App/assets/2319350/be9fb520-6e46-4801-988a-c3dad83a8176)

Yup @GandalfGwaihir that indeed looks like what we expect the behavior to be here, thanks for the video!

cc @thesahindia @mountiny for thoughts here - I think we picked an incorrect proposal and it looks like @GandalfGwaihir's proposal was actually what we were looking for.

What exactly is SubscriptAvatar? I don't think I understand the name of that. And I don't think I am following the rest of your comment. All I am trying to...

> SubscriptAvatar - This is a component that we used to display the avatar like workspace switcher button. @mountiny @kosmydel any context why we named it this way? This really...

Ah, got it. Wow... that still feels like quite the stretch of a name? Why not name it something more friendly like `AvatatarWithArrowButton` or something? I guess that's a different...

Cool, I don't feel too strongly from a technical perspective - definitely curious what the C+/engineers think about for that.