python-matrix-bot-api icon indicating copy to clipboard operation
python-matrix-bot-api copied to clipboard

Published 20 hours ago • verified publisher icon shawnanastasio

ENH: Allows to add rooms by specifying a string

Open quazgar opened this issue 6 years ago • 2 comments

There's also a new keyword arg for MatrixBotAPI: exclusive_rooms=True tells only the specified rooms should be used, all others will be left.

quazgar avatar Sep 05 '18 10:09 quazgar

Look at my PR, its logic is slightly better. If rooms specified, bot will be exclusive anyway. If not specified, bot will be listening on all of its rooms. Accept invites is the separated option.

mrdumpty avatar Jan 18 '19 07:01 mrdumpty

Hi @quazgar, thanks for the PR (and sorry for the late response)!

I think the ability to specify rooms by ID string is a useful feature, and your implementation looks good to me.

I'm not sure about the usefulness of the exclusive_rooms functionality you've added, though. Could you maybe explain the rationale for adding it? There's some discussion in PR #18, but it seems that its usefulness is limited, since users can already restrict which rooms the bot is active in with the rooms parameter.

shawnanastasio avatar Jan 22 '19 04:01 shawnanastasio