Steven Hawkins
Steven Hawkins
> Shouldn't the condition check that client is null instead? i.e. if (client == null) Absolutely those two instances need to be corrected. Also @cherifyazid are you able to update...
@cherifyazid @cobotrifork took a pass over the changes and made several refinements. There are now two new default methods on ClientsResource: - findClientByClientId returning an Optional ClientRepresentation - and getByClientId...
> Could you please resolve the conflicts? It's resolved, but unfortunately this will keep coming up as too many files are touched. If we don't see a path to get...
@mposolda @lhanusov @vmuzikar @cherifyazid based upon more feedback from @keycloak/cloud-native I'll stop updating this PR. If core-clients would entertain these some of these changes, we'll assign the PR to someone...
> @cherifyazid Thanks for understanding. Can we close this PR then? I'd let @mposolda make that call since he was last to triage the keycloak-client issue. If he or those...
@vmuzikar added an note in the changes.
Not sure what the javascript test is failing - seems to happen with our without the change to the default setting.
> When the version is not present, the default is used -> /clients -> /clients/v2 Is this for the dev experience? We shouldn't provide a endpoint with a schema that...
> Yes, the intention is mostly for dev experience - having the same convention as for features. I think the belief for features is that most version changes won't have...
> I'd vote for option 1 as it doesn't imply the realm is a resource – having /realms/ in a path suggests I can do e.g. GET /admin/api/clients/v2/realms/my-realm which is...