wyze-sdk icon indicating copy to clipboard operation
wyze-sdk copied to clipboard

Discarded start_time for retrieving records from Wyze Scale

Open jspalink opened this issue 2 years ago • 1 comments

First of all, thank you for this library - this is exactly what I've been looking for for building a connector from Wyze to Garmin Connect.

https://github.com/shauntarves/wyze-sdk/blob/284172fffe86c65a404a0e95e55535a11def597a/wyze_sdk/service/scale_service.py#L167

The start_time isn't passed to the wyze endpoints - instead the entire history is retrieved as the start_time is set here to 0.

jspalink avatar Sep 25 '22 03:09 jspalink

You're welcome to submit a PR for things like this that you find. I'm actually about 90% sure that when I coded this, the API wasn't actually honoring a non-zero start_time. I can play around with it a bit and see if that has changed. Or, if you have tinkered locally and confirmed it works, submit a PR and I'll merge and release

shauntarves avatar Sep 26 '22 21:09 shauntarves