react-d3-radar icon indicating copy to clipboard operation
react-d3-radar copied to clipboard

[Feature Request] Set domainMax for each Key

Open mcoeur opened this issue 6 years ago • 2 comments

First and foremost, thank you for this component !

I would love to be able to specify multiple domainMax (one for each key, and all sets will have the same domainMax for each key of course) so all axes don't have the same scale.

Is there any way to do that ? If anyone can point me to the place to start, I'd be willing to implement this and create a pull request.

mcoeur avatar Oct 04 '17 13:10 mcoeur

Thanks very much! I rarely get to hear how people are finding or using the library.

I think this should be possible. <RadarWrapper/> (the detailed component) only passes it on to draw the axes; instead we could have a dictionary of domainMaxes keyed by key. Inside <Radar/> things are a bit ugly (was originally a private lib) so it could benefit with a nicer API overall!

If you're up for it please go ahead. Otherwise I can do this 👍

shauns avatar Oct 04 '17 14:10 shauns

If you already know how to implement this, you will definitely be faster than me :-)

Otherwise I can give it a try in the weeks to come.

mcoeur avatar Oct 04 '17 14:10 mcoeur