ember-grid icon indicating copy to clipboard operation
ember-grid copied to clipboard

firefox is broken

Open shaunc opened this issue 10 years ago • 14 comments

tracking firefox problem separately from -- #25 Firefox display is broken currently.

It seems to start working when heights are set explicitly -- for me. You say you don't see anything in DOM at all? Is there a javascript error?

shaunc avatar Sep 14 '15 06:09 shaunc

Any particular version to test on?

lcpriest avatar Sep 15 '15 14:09 lcpriest

@lcpriest we're in the middle of refactoring the way scrolling is done, so please test on any browsers you have available. If you can fix any scroll issues with a PR without breaking them in other browsers you'll be a hero.

y-scroll should only scroll body section x-scroll should scroll header, body and footer together

Both scrollbars should only be visible if scrolling in that direction is required

BryanCrotaz avatar Sep 15 '15 14:09 BryanCrotaz

additional spec - header and footer heights should autosize to contents. Body should fill the remaining space.

BryanCrotaz avatar Sep 15 '15 14:09 BryanCrotaz

In your Ember London talk, you had a demo app already spun up - is that available for testing? Or should I build my own example app.

lcpriest avatar Sep 15 '15 14:09 lcpriest

it's the test dummy app.

ember serve

BryanCrotaz avatar Sep 15 '15 14:09 BryanCrotaz

it's also linked from the readme page on github, but we only push that when it's working so it's out of date!

BryanCrotaz avatar Sep 15 '15 14:09 BryanCrotaz

Just pushed a fix for firefox w/ native-scroll mode (which is turned on on macs and phones). Once we confirm that firefox works in windows/firefox we can close this issue.

shaunc avatar Sep 15 '15 17:09 shaunc

Chrome on Windows is broken. No y-scrollbar and column widths broken in "scroll columns"

image

image

image

BryanCrotaz avatar Sep 16 '15 08:09 BryanCrotaz

Will spin up a windows machine later today....

shaunc avatar Sep 16 '15 13:09 shaunc

Sorry I can't help. Doing a 22 hour day for a client including 10 hours of driving...

BryanCrotaz avatar Sep 16 '15 13:09 BryanCrotaz

ok ... thought I wouldn't get to it but pushed something for windows/chrome.

Hope you made it home safely!

shaunc avatar Sep 17 '15 06:09 shaunc

YAY!!! It works. (windows+chrome)

BryanCrotaz avatar Sep 18 '15 00:09 BryanCrotaz

Wow - Firefox, go home - you're drunk.

Firebug's log limit has been reached. 0 entries not shown. Preferences
this.window.console.error.bind is not a function [Break On This Error] error: this.window.console.error.bind(this.window.console) livere...ipver=1 (line 301) Accessors not supported! [Break On This Error] if('get' in Attributes || 'set' in...ypeError('Accessors not supported!'); vendor.js (line 1456) Could not find module ember imported from dummy/app [Break On This Error] throw new Error('Could not find ... 'imported from' + origin + '`');

BryanCrotaz avatar Sep 18 '15 00:09 BryanCrotaz

... sigh ... it seems we are pushing the limits of browser compatibility... I asked testem whether I could set windows tests on virtual machines -- but no response yet.

Maybe I'll try to figure out how to do this on my own using docker, as it seems that, even when we get our test suite in shape, passing in phantomjs doesn't necessarily translate into passing in browser X.

shaunc avatar Sep 18 '15 00:09 shaunc