rlace-icml

rlace-icml copied to clipboard

Train used instead of dev in solve_adv_game

1

I think this line is wrong and should pass X_dev & y_dev as "X_dev/y_dev" parameters. https://github.com/shauli-ravfogel/rlace-icml/blob/2d9b6d03f65416172b4a2ca7f6da10e374002e5f/rlace.py#L188 X_dev & y_dev are not used inside the whole function.

FabienRoger

Hello! I stumbled upon what i think might be a typo in the paper:  In the lower part (the formula for the optimal P) i believe the second y...

Heyjuke58

The website for the data, i.e., https://nlp.biu.ac.il/~ravfogs/rlace-cr/, can't be reached.

afsharim