Shashwathi comments

Results 15 comments of


                                            Shashwathi

Timeout of build may have problem

> Is it possible to remove work items when we see the build has completed? We already do that in build controller. `syncHandler` does not return error for successful/completed builds...

Timeout of build may have problem

Instead of trying to `Forget()` the work item in the code, how about not returning error for timedout builds. As of now once build times out, we delete all corresponding...

Timeout of build may have problem

Thanks @zrss for detailed comment about workqueue. That was very helpful to understand underlying operations of Queue. In the spirt of containing the discussion to reducing the build timeout granularity...

Ability to generate contour clients

Yeah it would be great if the patch is in upstream.

--dry-run fails with workload create for pre-existing workload and returns full workload object with status rather than just example of what would be created/applied.

For context, in CLI `dry-run` is implemented with server side strategy, i.e., object is submitted to the API but not persisted. To allow users to use `dry-run` without submitting to...