clx icon indicating copy to clipboard operation
clx copied to clipboard
verified publisher icon sharplispers

extensions: randr: fix RR-GET-OUTPUT-INFO indices

Open paulapatience opened this issue 5 years ago • 4 comments

The CRTC-START index was incorrect, which caused RR-GET-OUTPUT-INFO to return bogus CRTCs, modes, clones, and name.

Additionally, document the function's multiple return values and declaim its type. The latter required adding some types and adjusting some existing types and constants.

Finally, reindent RR-GET-OUTPUT-INFO, wrap some overlong lines, and clean up some comments and whitespace.

paulapatience avatar Jun 25 '20 14:06 paulapatience

please resolve conflicts; after that I'm OK with merging this as is. thank you.

dkochmanski avatar Jul 13 '20 15:07 dkochmanski

What's the status on this?

einsiedlerspiel avatar Nov 10 '22 16:11 einsiedlerspiel

What's the status on this?

I can take a look at this again soon. However, I wonder if I should revert the &keys back to &optionals, as @JMC-design disapproved of the change in https://github.com/sharplispers/clx/pull/174#pullrequestreview-491477704.

paulapatience avatar Nov 20 '22 05:11 paulapatience

key is fine, it makes the interface better. optional arguments get nasty quick if there is more than one.

dkochmanski avatar Nov 20 '22 09:11 dkochmanski