minigalaxy
minigalaxy copied to clipboard
sharkwouter
Specific game stuck "in queue"
Minigalaxy ver: 1.1.0
Specific game is "The Legend of Heros: Trails in the Sky". Only this game exhibits this behavior, all other games linux native or windows download correctly. Additionally, when minigalaxy is started from the console, attempting to install the game produces no error message.
Thanks for the report! Could you try running the code in the master branch to see if the issue is still there? I'm planning on doing a new release soon
I'm currently using the aur package @ https://aur.archlinux.org/packages/minigalaxy
There is also a "git" package @ https://aur.archlinux.org/packages/minigalaxy-git
Would trying the git version work?
On Tue, May 3, 2022, 3:18 AM Wouter Wijsman @.***> wrote:
Thanks for the report! Could you try running the code in the master branch to see if the issue is still there? I'm planning on doing a new release soon
— Reply to this email directly, view it on GitHub https://github.com/sharkwouter/minigalaxy/issues/484#issuecomment-1115942866, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY7QQ5LF4ISHVBQLLCQRQ3DVID4QRANCNFSM5U47MI4A . You are receiving this because you authored the thread.Message ID: @.***>
Ok, just tried the git version, no difference. Game still stays stuck in download queue.
Additional info: When starting non-git and git packages from the console, the app would not complete shutdown (return to console prompt) until I ctl-c to close. This is the output from both packages (console output from both are identical):
^CException ignored in: <module 'threading' from '/usr/lib/python3.10/threading.py'> Traceback (most recent call last): File "/usr/lib/python3.10/threading.py", line 1560, in _shutdown lock.acquire() KeyboardInterrupt:
Not sure if this is related or something else entirely.
On Tue, May 3, 2022 at 7:33 AM Wouter Wijsman @.***> wrote:
Yes, that should work
— Reply to this email directly, view it on GitHub https://github.com/sharkwouter/minigalaxy/issues/484#issuecomment-1116172642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY7QQ5NKGSK7VWUGTK7OP6DVIE2K7ANCNFSM5U47MI4A . You are receiving this because you authored the thread.Message ID: @.***>
Ok, I'm thinking that not fully closing when starting from the console might be a separate issue. I just opened minigalaxy from the console and tried closing via the close window button (big red X in upper right corner of window) and the same thing happened. Didn't even try and install anything, just started and tried to close the app. I can open up a new issue for that if necessary.
On Tue, May 3, 2022 at 8:29 AM James Williams @.***> wrote:
The console output? No idea, I can try with a game that does download and see if it happens again.
On Tue, May 3, 2022 at 8:18 AM Wouter Wijsman @.***> wrote:
Interesting, does that only happen if it did not get stuck before?
— Reply to this email directly, view it on GitHub https://github.com/sharkwouter/minigalaxy/issues/484#issuecomment-1116221539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY7QQ5I4S7OLJVDTJYUFA7LVIE7STANCNFSM5U47MI4A . You are receiving this because you authored the thread.Message ID: @.***>
@sharkwouter The problem is the same that i had month ago with Batman Arkham Asylum. We discussed about that on Discord.
The problem is in gametile.py/__download function. It stuck about "total_file_size" and md5sum.
Quote these call workaround the issue
~~Oh that is useful information. That would mean this is fixed on the master branch right now. @fefniir could you test is the workaround bby @Kzimir works?~~
Edit: now that I think about this again, we've already tested if it's the issue mentioned here ☹
Oh that is useful information. That would mean this is fixed on the master branch right now. @fefniir could you test is the workaround bby @Kzimir works?
In fact, it's not really fixed in master... Because even with your commit #470, i still have the issue. Victor Vran game has this issue when i want to download/install the Windows version. No issue with Linux version.
Will do, as soon as I get back to the house.
On Mon, May 16, 2022, 5:22 AM Maxime Lombard @.***> wrote:
Oh that is useful information. That would mean this is fixed on the master branch right now. @fefniir https://github.com/fefniir could you test is the workaround bby @Kzimir https://github.com/Kzimir works?
In fact, it's not really fixed in master... Because even with your commit #470 https://github.com/sharkwouter/minigalaxy/pull/470, i still have the issue. Victor Vran game has this issue when i want to download/install the Windows version. No issue with Linux version.
— Reply to this email directly, view it on GitHub https://github.com/sharkwouter/minigalaxy/issues/484#issuecomment-1127604582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY7QQ5PW5QUCCDOP6SQAMFLVKI4XTANCNFSM5U47MI4A . You are receiving this because you were mentioned.Message ID: @.***>
That is really interesting, then there is still a scenario which is not included in the tests at the moment. I'll have to investigate, especially if your work around works.
I downloaded/installed the minigalaxy-git package from the AUR and made the modifications to the gametile.py file. Interesting, it is downloading, however there was a significant pause between clicking on download and the game downloading (2 minutes or so).
SUCCESS!! The game has been downloaded, installed and does run.
On Mon, May 16, 2022 at 5:47 AM Wouter Wijsman @.***> wrote:
That is really interesting, then there is still a scenario which is not included in the tests at the moment. I'll have to investigate, especially if your work around works.
— Reply to this email directly, view it on GitHub https://github.com/sharkwouter/minigalaxy/issues/484#issuecomment-1127629615, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY7QQ5O4J6NZGQ3XIUC4GSLVKI7UHANCNFSM5U47MI4A . You are receiving this because you were mentioned.Message ID: @.***>
Oh wow, thanks @fefniir and @Kzimir! That is super helpful information. I'll do some debugging to see what's wrong with these functions.
I'm going to keep this open to better track it, as there is no fix for it in master yet.
Hey, no worries! You do whatever you need to do.
On Thu, May 19, 2022, 1:07 AM Wouter Wijsman @.***> wrote:
I'm going to keep this open to better track it, as there is no fix for it in master yet.
— Reply to this email directly, view it on GitHub https://github.com/sharkwouter/minigalaxy/issues/484#issuecomment-1131376249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY7QQ5JRSVMHAR5OS4TQRJTVKXZFHANCNFSM5U47MI4A . You are receiving this because you modified the open/close state.Message ID: @.***>
Oh, before I forget. Some additional info, that may or may not be relevant:
The, previously mentioned, download delay seems to be highly variable. I have downloaded that game 3 times in the last 24 hours. The first took about 5 minutes to start, the 2nd about 30 seconds, and the 3rd time time took about 15 minutes.
Hi Guys, I also have this issue.
I am trying to download Chorvs and it gets stucked in queue.
I tested running the app from the command line to see if I could get additional info.
This is the error I get maybe it helps...
The issue is still here for the chaotic-aur package in arch. I applied the patch directly, commented the total_file_size line -> no change commented the md5sum line -> download finally starts ! It was for daggerfall unity.
I've made some more adjustments which should fix this issue. Could anyone do a test on the master branch?
I've downloaded and built AUR package minigalaxy-git. First attempt, no modifications: Failed to download Second attempt, as with zelurker, commented the md5sum lines: Successful download and install after an approximately 5 minute wait.
Thanks for testing. I'll try some other things. I'm having a hard time reproducing this, as I don't have the games mentioned in this thread. I'll try to see if I can find more games with this issue.
Can anyone check if this issue still exist when using the branch bugfix/484?
I've merged the fix I wrote to master, since it does resolve an issue regardless of if it resolves this issue specifically. Can someone test if it works for them?
The console output? No idea, I can try with a game that does download and see if it happens again.
On Tue, May 3, 2022 at 8:18 AM Wouter Wijsman @.***> wrote:
Interesting, does that only happen if it did not get stuck before?
— Reply to this email directly, view it on GitHub https://github.com/sharkwouter/minigalaxy/issues/484#issuecomment-1116221539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY7QQ5I4S7OLJVDTJYUFA7LVIE7STANCNFSM5U47MI4A . You are receiving this because you authored the thread.Message ID: @.***>