minigalaxy icon indicating copy to clipboard operation
minigalaxy copied to clipboard

No documentation on "Variable flags" or "Command flags"

Open Fluffkin opened this issue 3 years ago • 6 comments

Looking in a game's properties gives these two fields. I can't find any documentation on what they do.

(In the context, how does this help to run wine vs. native games? For example)

Fluffkin avatar Feb 22 '22 01:02 Fluffkin

Good point, this should probably be improved.Variable flags get added in front of the command which is used to run the game, command flags after. A tooltip would be a good start.

sharkwouter avatar Feb 22 '22 09:02 sharkwouter

Looking at the main branch right now, these tool tips seem to be present in properties.ui as you have described.

<object class="GtkEntry" id="entry_properties_variable">
    <property name="visible">True</property>
    <property name="can_focus">True</property>
    <property name="tooltip_text" translatable="yes">Added in front of the command used to launch the game</property>
    <property name="halign">start</property>
</object>

So not sure if you are looking for more updates here?

bclaesen avatar Apr 03 '22 05:04 bclaesen

It was more of a concern for wine programs. If "wine program" is the standard start, is it "<variable flags> wine program <command flags>", or "wine <variable flags> program <command flags>" ? It would actually be useful to be able to specify "<variable flags> wine <wine commands> program <command flags>", assuming that's how it works. Giving access to /desktop...

Fluffkin avatar Apr 04 '22 00:04 Fluffkin

Do you have any examples of <wine commands>? All I can find is the following:

Usage: wine PROGRAM [ARGUMENTS...]   Run the specified program
       wine --help                   Display this help and exit
       wine --version                Output version information and exit

which indicates there might not be any, but you seem to hint towards passing arguments?

Otherwise the syntax would indeed be <variable flags> wine program <command flags>

That could be documented with examples indeed (such as using WINEDLLOVERRIDES in variable flags, and -screen-width 3840 for command flags.

bclaesen avatar Apr 06 '22 06:04 bclaesen

The main gaming use is wine explorer /desktop=name,1024x768 program.exe as an example.

The name is required otherwise all wine virtual desktops have the same naming. If you're using something like KDE / Devilspie2 / Openbox to manipulate window size / position / decorations based on name, it's vital to allow distinguishing between applications.

Unfortunately, some wine games do require running in a virtual desktop to obtain a reasonable window / resolution.

Fluffkin avatar Apr 06 '22 07:04 Fluffkin

Ah, got it! Thank you.

In my understanding that might not be possible with the current way these variables are used:

https://github.com/sharkwouter/minigalaxy/blob/729d3439a585ab50378bc5f35bedda5f3d1886ba/minigalaxy/launcher.py#L96 where exe_cmd is either wine <X> or wine start /b /wait /d <XworkingDir> <X> for wine games.

Documentation could indicate that winecfg should be used to set a virtual desktop, but as setting the name per instance, that seems like a new feature (though I am new to the source code :)).

bclaesen avatar Apr 06 '22 08:04 bclaesen