minigalaxy
minigalaxy copied to clipboard
sharkwouter
Windows installers create useless shortcuts
This is especially annoying now you can no longer disable the option in the installer. The shortcuts which are created in the menu and on the desktop link to files which don't exist, since the installed files are moved after installation. According to the documentation you should be able to prevent the icons from being created using the /NOICONS option, but I tested this and it is not the case.
Here is the documentation: https://jrsoftware.org/ishelp/index.php?topic=setupcmdline
It may be possible to explicitly not run certain steps (tasks) in the installation process.
This issue is now partially solved as we can now use innoextract to prepare wine game. I believe that proper way to address it is to remove those wrong shortcuts. #343 will deal with creation of proper shortcuts.
It seems that wrong shortcuts are localized in (for example): " ~/.local/share/applications/wine/Programs/GOG.com/Battle\ Realms\ Complete/'Battle Realms Complete.desktop' " And they example content is: " [Desktop Entry] Name=Battle Realms Complete Exec=env WINEPREFIX="/home/itwasonlyabug/GOG Games/Battle Realms Winter of the Wolf/prefix" wine C:\\windows\\command\\start.exe /Unix /home/itwasonlyabug/GOG\ Games/Battle\ Realms\ \ Winter\ of\ the\ Wolf/prefix/dosdevices/c:/ProgramData/Microsoft/Windows/Start\ Menu/Programs/GOG.com/Battle\ Realms\ Complete/Battle\ Realms\ Complete.lnk Type=Application StartupNotify=true Path=/home/itwasonlyabug/GOG Games/Battle Realms Winter of the Wolf/prefix/dosdevices/z:/home/itwasonlyabug/.cache/minigalaxy/extract/1207659111/ Icon=92D0_gfw_high.0 StartupWMClass=battle_realms_f.exe "
I think that during installation we should check all .desktop files in "~/.local/share/applications/wine/Programs/GOG.com/" and if the contain "/.cache/minigalaxy/extract/" remove them.
If Innoextract is installed this shouldn't happen anymore. In the case of the fallback being used this is still a problem, though.
This issue makes me wonder if we should add Innoextract as a dependency. We probably should, although, wine is also optional.