Emmanuel Thompson
Emmanuel Thompson
@wcampbell0x2a is this ready for review / 0.18? I'll need to allocate some time to review this one
> Remove support for defining both id = 1 and having a discriminant I'm not convinced yet we want to do this as it removes some flexibility (what if I...
Hi @goto40 thanks for the PR! I wouldn't block merging on this requirement. It's more-so meant as a guideline. As long as tests are included which covers what we're changing,...
Thanks for bringing this up, I also agree it seems counter-intuitive, until you understand how it's implemented. Is there a better way? Maybe...? I'm not sure either. @wcampbell0x2a has explained...
> > I also agree it seems counter-intuitive, until you understand how it's implemented. > > I don't agree with this, I think you're confusing "reasonable" with "intuitive" Right, intuitive...
> As for how to document this, since this is not really an easy thing to explain, maybe just say "there're some quirks around member endian handling" with a link...
yeah, wonder if we can enforce that somehow at compile time
fixed by https://github.com/sharksforarms/deku/pull/554
wow this looks great, I owe you a review. To set expectations I'm busy for a while w/ work so it may need to wait a bit, but I'm very...
Enums work by reading a given identifier (id) and matching it to an enum variant. It generates a match statement under the hood. Here, you're specifying `id_type = u8` and...