Test refactoring

Open pwithams opened this issue 5 months ago • 2 comments

I saw https://github.com/sharkdp/fd/issues/382 and was interested in helping out.

Specifically regarding https://github.com/sharkdp/fd/issues/382#issuecomment-894977261 I see that integration tests are all under a single tests/tests.rs. I took a look at some possible simple test groupings, such as:

and.rs  exec.rs  glob.rs  ignore.rs  owner.rs  symlink.rs  tests.rs

Shared static globals could be moved to testenv or a separate utils helper module.

Is there still any interest in splitting these into separate files? Or any other refactorings?

Jun 28 '25 05:06 pwithams

That seems reasonable to me.

Jun 29 '25 03:06 tmccombs

Sounds good, I created a PR: https://github.com/sharkdp/fd/pull/1745

Jul 04 '25 03:07 pwithams