Added JSONC and aws credentials to the syntax mappings
I'm not 100% sure this is where these should be added.
Let me know if I need to move them somewhere else.
Thank you for the PR. Let's wait with this PR until after https://github.com/sharkdp/bat/pull/2755 has landed to avoid creating conflicts.
Thank you for the PR. Let's wait with this PR until after #2755 has landed to avoid creating conflicts.
Thanks for the update, let me know when it's viable to get this added, I'll fix the branch/pr conflicts then 😄
#2755 is now merged
#2755 is now merged
Does #2755 add support for jsonc files?
Or do I need to fix my merge?
I'm pretty sure no actual changes were made to what mappings are applied by default in that PR, and I see no mention of JSONC in the changes
Alright, I'll rebase this PR on new master branch
I've applied my changes to the new structure, not 100% sure that it's done correctly though, let me know if anything needs changing.
Shouldn't AWS config & credentials be parsed as TOML instead of INI?
Shouldn't AWS
config&credentialsbe parsed as TOML instead of INI?
I'm not sure, the official amazon docs that I looked at did not mention if it was toml formatted, but from the examples, it looks like simple INI format to me.
Granted, basic INI if I remember correctly is valid TOML as well.
Shouldn't AWS
config&credentialsbe parsed as TOML instead of INI?I'm not sure, the official amazon docs that I looked at did not mention if it was toml formatted, but from the examples, it looks like simple INI format to me.
Granted, basic INI if I remember correctly is valid TOML as well.
conclusion: INI is correct 👍️