bat icon indicating copy to clipboard operation
bat copied to clipboard

Added JSONC and aws credentials to the syntax mappings

Open mxaddict opened this issue 2 years ago • 4 comments

I'm not 100% sure this is where these should be added.

Let me know if I need to move them somewhere else.

mxaddict avatar Dec 07 '23 08:12 mxaddict

Thank you for the PR. Let's wait with this PR until after https://github.com/sharkdp/bat/pull/2755 has landed to avoid creating conflicts.

Enselic avatar Dec 28 '23 22:12 Enselic

Thank you for the PR. Let's wait with this PR until after #2755 has landed to avoid creating conflicts.

Thanks for the update, let me know when it's viable to get this added, I'll fix the branch/pr conflicts then 😄

mxaddict avatar Dec 28 '23 22:12 mxaddict

#2755 is now merged

sharkdp avatar Jan 21 '24 19:01 sharkdp

#2755 is now merged

Does #2755 add support for jsonc files?

Or do I need to fix my merge?

mxaddict avatar Jan 22 '24 01:01 mxaddict

I'm pretty sure no actual changes were made to what mappings are applied by default in that PR, and I see no mention of JSONC in the changes

keith-hall avatar Feb 08 '24 07:02 keith-hall

Alright, I'll rebase this PR on new master branch

mxaddict avatar Feb 10 '24 14:02 mxaddict

I've applied my changes to the new structure, not 100% sure that it's done correctly though, let me know if anything needs changing.

mxaddict avatar Feb 10 '24 20:02 mxaddict

Shouldn't AWS config & credentials be parsed as TOML instead of INI?

akkadaya avatar May 13 '24 22:05 akkadaya

Shouldn't AWS config & credentials be parsed as TOML instead of INI?

I'm not sure, the official amazon docs that I looked at did not mention if it was toml formatted, but from the examples, it looks like simple INI format to me.

Granted, basic INI if I remember correctly is valid TOML as well.

mxaddict avatar May 16 '24 14:05 mxaddict

Shouldn't AWS config & credentials be parsed as TOML instead of INI?

I'm not sure, the official amazon docs that I looked at did not mention if it was toml formatted, but from the examples, it looks like simple INI format to me.

Granted, basic INI if I remember correctly is valid TOML as well.

image

mxaddict avatar May 16 '24 14:05 mxaddict

conclusion: INI is correct 👍️

keith-hall avatar May 16 '24 18:05 keith-hall