Shargon

Results 653 comments of Shargon

https://github.com/neo-project/neo/blob/0de52d2ef7a3acb5daa2a0f7d8c480dabcf82705/src/Neo/Wallets/Wallet.cs#L81 Call `CreateAccount(account)` after extract the pk from wif

> But that's an abstract method. Where can I find an implementation? [Nep6Wallet](https://github.com/neo-project/neo/blob/0de52d2ef7a3acb5daa2a0f7d8c480dabcf82705/src/Neo/Wallets/NEP6/NEP6Wallet.cs#L28) for example

> Fix the build & release process to generate valid neo-cli executables What is wrong?

should say, contact mac to find out why it says this hahaha

I think we should use the same, if we decide migrate it, its ok, but a mix is worse

> For me i think it is OK to use either test engine. as long as it works. We dont have such rule of using same test engine before. We...

I will continue tomorrow with the review, @cschuchardt88 good work!

Ban method should be by endPoint instead of controller before merge, some methods are prone to denial of service