discordrb icon indicating copy to clipboard operation
discordrb copied to clipboard

Published 20 hours ago • verified publisher icon shardlab

Fixes rubocop and specs

Open PixeLInc opened this issue 2 years ago • 1 comments

Summary

This pr fixes the long broken rubocop, along with the failing specs. So we are now green bois again.

Fixed

  • examples/modals.rb to use ENV.fetch instead of ENV[...]
  • lib/discordrb/data/interaction.rb to prefer proc rather than a block to please lord rubocop.
  • spec/data/webhook_spec.rb failing due to missing hash_including call..
  • spec/api/channel_spec.rb failing due to double quotes around the unicode emoji

PixeLInc avatar Dec 29 '22 06:12 PixeLInc

Fixing the webhook problem does not require changing the test, but fixing the bug in the class directly. I already did it in one of my last PR

https://github.com/shardlab/discordrb/pull/192/commits/591d1277d265d5d57db2fa77ae311f792044d8a5

Dakurei avatar Dec 29 '22 09:12 Dakurei