roast.vim icon indicating copy to clipboard operation
roast.vim copied to clipboard

Compatibility with Neovim

Open JulioJu opened this issue 6 years ago • 1 comments

Hi !

Actually this plugin is not compatible with Neovim, even if with a simple vimrc.

Actually, when we press enter twice in a link GET http://google.fr, the second time we have an error.

Error detected while processing function roast#run[1]..provider#python3#Call:                                                                                                         
line   18:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/julioprayer/.vim/plugged/roast.vim/python3/roast.py", line 39, in run
    show_response(response)
  File "/home/julioprayer/.vim/plugged/roast.vim/python3/roast.py", line 49, in show_response
    workspace_renderer = window.buffer.vars['_roast_renderer'].decode()
AttributeError: 'str' object has no attribute 'decode'

Furthermore <c-j> doesn't work:

Error detected while processing function provider#python3#Call:                                                                                                                        
line   18:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/julioprayer/.vim/plugged/roast.vim/python3/roast.py", line 111, in next_render
    renderer = vim.current.buffer.vars['_roast_renderer'].decode()
AttributeError: 'str' object has no attribute 'decode'

Please, could you implement compatibility with Neovim ? As Neovim is very better than Vim, it could be very cool… Actually I use Vim instead of Neovim to use your pluggin, but Vim lack lot of features (terminal less good, no floating window, no live search and replace, etc.)

Thanks a lot in advance :-)

JulioJu avatar May 02 '19 15:05 JulioJu

I have this in the after stability features list, but yeah, I do want to do this. Thanks for creating an issue!

sharat87 avatar May 03 '19 11:05 sharat87