Sharadh Rajaraman comments

Results 53 comments of


                                            Sharadh Rajaraman

Use `import std;` guarded by macro

There's a bit of a problem here and I'd like some thoughts. I'm defining the macro `VULKAN_HPP_CPP_STD_MODULE` in `vulkan_hpp_macros.hpp` based on the platform and compiler characteristics. This means we need...

Comprehensive testing, CI, and CD for `vulkan.cppm`

@M2-TE now that we've merged in #2303 maybe we can work towards resolving and closing this, also now that most recent compilers are happy to support named modules. I need...

Use `import std;` guarded by macro

I'm not sure that is a good resolution: [this blog post](https://vector-of-bool.github.io/2019/10/07/modules-3.html) says: > C++ Modules is almost entirely agnostic to the existence of the preprocessor. What you’ve just done in...

Use `import std;` guarded by macro

I think your initial claim is misconstrued—you've quoted the standard: > http://eel.is/c++draft/cpp#import-3: > If a [pp-import](http://eel.is/c++draft/cpp#nt:pp-import) is produced by source file inclusion (including by the rewrite produced when a #include...

Use `import std;` guarded by macro

Actually, I misconstrued that myself too. That line refers to a module 'group', which is the part between `export module vulkan_hpp;` and the end of the file, or `module :private;`....

Use `import std;` guarded by macro

I'm not entirely sure why the CI tasks are failing so badly... @asuessenbach, any thoughts?

Use `import std;` guarded by macro

Now that you mention it, I do see that build failure on MSVC, but I'm not sure it's relevant to this PR. In particular, https://github.com/KhronosGroup/Vulkan-Hpp/blob/d86b49ca041b9be51afb105668312925719845d0/tests/UniqueHandleDefaultArguments/UniqueHandleDefaultArguments.cpp#L29 needs to be: ```diff -...