shapirus
shapirus
FWIW, it is still an issue in the second half of 2023. It takes about 30-40 seconds for new connections to stop being sent to the target _after_ it gets...
So there were two releases that clearly made PSM performance worse: 1) 3.8.0; 2) 00f0fd71. #2987, which was specifically referring to PSM (created for 00f0fd71) is closed with #4568, which...
> I expect that, if https://github.com/kubernetes-sigs/kustomize/pull/4568 did the job, PSM performance will become 5x faster than the release before it. That's precisely what happened! Here are the test results with...
Nevermind, there's just a few commits between 3.7.0 and 3.8.0. I tested all of them: ``` ### Starting benchmark on Linux x86_64 # kustomize versions: 42d1f7b7 d3a7335b def00220 5a022862 6a50372d...
And [this](https://github.com/kubernetes-sigs/kustomize/commit/d3a7335bbca04aa000c5d74280a54dafaae5fc13#diff-8c87cae2a0d0df36343b14e8349b3d2b655e8eeeb098f86a2663964d7a232685) is the most likely chunk of code that could introduce it (so the actual commit is d3a7335b, whereas 5a022862 is when it actually started to be used). This...
> The effect of the one-time extra cost would be most significant to users that have lots of kustomize invocations against a large number of small builds. If I remember...
I did some profiling, for both the `go test` and standalone binary execution scenarios. pprof-compatible files are attached: [kustomize-5422-profiles.zip](https://github.com/kubernetes-sigs/kustomize/files/13195083/kustomize-5422-profiles.zip) Standalone profiles were made for the following test cases: 1) PSM;...
> I'm afraid that at this point I finally lack the knowledge required to try and refactor this code, or comment out certain parts to see if something improves performance....
...still no ideas on the PatchesStrategicMerge performance issue? It's the only thing that is still slow.
> I haven't had time to investigate anything recently, sorry. That's fine, no worries. It was more like a keep-alive packet to prevent the overly intelligent bots from auto-closing the...