web icon indicating copy to clipboard operation
web copied to clipboard

remove restrictions on contracts interacting with TC

Open 0xean opened this issue 1 year ago • 1 comments

The white list has been removed -

https://discord.com/channels/838986635756044328/839001804812451873/1255927290785697833

So this means that a Safe wallet connected via WC should be able to transact with TC now.

We should remove the restriction and test the functionality to ensure it works before rolling it out

0xean avatar Jun 28 '24 20:06 0xean

Testing https://github.com/shapeshift/web/pull/7277 and there may be some ramifications to this - even though TC did lift the smart contract limitations, THOR Txs being happy (i.e seen by the network) is really assuming msg.sender is the smart contract signer, i.e connecting to a safe through WC will show the safe address as a connected address, but the msg.sender of the actual Tx will be whichever address executed it, i.e the last signer.

This means that while the Tx will be succesful (no lost funds), the THOR Tx will be seen as initiating from the signer's address, which isn't the desired behavior. This was not visible previously as we disabled smart contract wallets interaction, but may become an issue if we land that PR in.

gomesalexandre avatar Jul 01 '24 10:07 gomesalexandre

closing https://github.com/shapeshift/web/pull/7277 for now since we are going to just enable this for swapper.

0xean avatar Jul 29 '24 22:07 0xean