web icon indicating copy to clipboard operation
web copied to clipboard

Make ShapeShift as a WalletConnect dApp connect to all accounts in the request

Open woodenfurniture opened this issue 1 year ago • 1 comments

Overview

When a wallet connects (as a wallet) to ShapeShift (as a dApp) via WalletConnect, ShapeShift should display all accounts allowed by the request. Currently we do not, and only show the first account in the request.

As noted about @woodenfurniture, we are probably not handling the accounts a wallet gives us in the session payload when we are connected as a dApp, as we just use the existing logic to derive accounts, and so I assume if a wallet gives us an account with 0 balance in the session request we don't actually show it in ShapeShift without manually adding it.

References and additional details

Originally spiked in #6691 .

Example showing Ledger Live connected to ShapeShift with 2 accounts enabled on the wallet side, but only 1 appearing in the app:

image

Acceptance Criteria

All accounts enabled in a WalletConnect request from a wallet to ShapeShift as a dApp should appear in ShapeShift.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

woodenfurniture avatar Jun 13 '24 02:06 woodenfurniture

less than 3% of connect wallets are WC, low priority for now

0xean avatar Oct 07 '24 17:10 0xean

closing as usage of WC is just super low. 100k in volume over last 6 months from WC

0xean avatar Jan 06 '25 18:01 0xean