web
web copied to clipboard
Related assets selection is allowing dangerous unsupported assets selection
Overview
See Jam below. Lending correctly has narrowed down asset selection for borrows and repays.
For borrows
- the asset selection list is disabled for deposit asset as it should ✅
- the asset selection list is properly narrowed down for the borrow asset as it should ✅
- related assets are narrowed down to only the THOR-supported ones on the borrow side ✅
- related assets are not properly narrowed down on the deposit side 🚫 For repayments:
- the asset selection list is disabled for the unlocked collateral as it should ✅
- it is possible to select a related asset despite the collateral unlocked asset being disabled 🚫
- the asset selection list is properly narrowed down for the repayment asset, but its related assets list isn't. 🚫
This is not putting user funds at risks as we simply won't be able to get a THOR asset from said asset and will bail, and even if we didn't still wouldn't be able to get a quote for an invalid asset, but should be fixed regardless.
References and additional details
N/A
Acceptance Criteria
- THOR repayments related assets are properly narrowed down
Need By Date
No response
Screenshots/Mockups
https://jam.dev/c/881ce400-4e82-4d55-9783-0fc3eef4e72b
Estimated effort
No response