web icon indicating copy to clipboard operation
web copied to clipboard

Differentiate between "chain not supported" and "chain not connected"

Open woodenfurniture opened this issue 1 year ago • 1 comments

Overview

Some wallets (e.g ledger, metamask with snap) support some chains without being connected to the app at runtime, while totally not supporting others (e.g metamask without snap). Currently we display both cases as "chain not supported".

It could be nicer to differentiate these two concepts in the app as "chain not connected" and "chain not supported"

References and additional details

Example: Ledger supports BNB smart chain and THORChain, but we current say it's usupported until the user connects both chains to the app:

image

This is a non-trivial change, as it involves rewrites of many of the existing logic in the swapper and other features, as 2 initial examples: src/hooks/useWalletSupportsChain/useWalletSupportsChain.ts src/pages/ThorChainLP/components/AddLiquidity/AddLiquidityInput.tsx -> walletSupportsOpportunity

Acceptance Criteria

Wallet supported chains should be communicated as "not connected" instead of "not supported".

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

woodenfurniture avatar May 14 '24 03:05 woodenfurniture

@woodenfurniture I see there was a PR to only show connected chains now. Is this good then and can be closed?

reallybeard avatar Jul 16 '24 20:07 reallybeard

@woodenfurniture - can we close?

0xean avatar Jan 06 '25 18:01 0xean