web icon indicating copy to clipboard operation
web copied to clipboard

feat: mobile trade changes

Open reallybeard opened this issue 1 year ago • 0 comments

Description

  • removes nav from trade page
  • fixes the button to the bottom of the screen
  • adjusts stylings to give it more of a native feel
  • To prevent endless loop, changed the redirect for mobile to /home instead of /trade. Now there will be history when the user taps on the back arrow on trade.

Pull Request Type

  • [ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
  • [ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • [x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6436

Risk

High Risk PRs Require 2 approvals

Although I just touched the styles, I would consider this high risk because its trade.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

Operations

On desktop confirm that trade works as expected through the full lifecycle.

On mobile, you should be taken to the home screen once connecting your wallet. From there you can go to trade via the actions menu (blue circle in mobile nav) Make a trade as you would normally, check that you can expand the trade details section and switch quotes. And that you can easily navigate back and forth.

Screenshots (if applicable)

Screenshot 2024-05-08 at 2 16 47 PM Screenshot 2024-05-08 at 2 16 51 PM Simulator Screenshot - iPhone 15 Pro - 2024-05-08 at 14 15 59

reallybeard avatar May 10 '24 19:05 reallybeard