web
web copied to clipboard
Thorchain lending slippage levels
ticket replacing this one https://github.com/shapeshift/web/issues/6577
-
Implement slippage color / warning scheme in thorchain lending. Follow the same pattern used in the swapper and same heuristics.
-
double check on LP to see if we can extend there as well
-
[x] pull health tag should reflect Active or Halted state rather than Healthy (completed)
@shapeshift/product
What I did on LP:
If it's something else than Available
, it will display Halted
with a red tag
I also added the fact that we display every pools we support even if the status is halted, here is a monkey patched example:
It actually doesn't change anything and will almost never be shown as loan_collateral
will mostly be 0, we actually end up with BTC and ETH pool for now but it works!
Pools:
We already handle the status:
BorrowInput: we already handle the slippage Acknowledge warning RepayInput: Missing the slippage acknowledge warning, I'll add it in the same PR
Do I miss anything regarding heuristics? Is that enough?
Sounds right. It's that tag, e.g., if a lending pool is at capacity it shouldn't show as healthy.
It should say active probably.
- We have acknowledgement almost everywhere except in
RepayInput
- Status are reflecting the real status of Lendings
If someone has a loan to repay or can deposit in the LP at one time because it's a bit emptier, feel free to finish this but it's pretty hard to test on my side for now
potentially closing based on upcoming TC vote