web icon indicating copy to clipboard operation
web copied to clipboard

Thorchain lending slippage levels

Open 0xean opened this issue 9 months ago • 3 comments

ticket replacing this one https://github.com/shapeshift/web/issues/6577

  • Implement slippage color / warning scheme in thorchain lending. Follow the same pattern used in the swapper and same heuristics.

  • double check on LP to see if we can extend there as well

  • [x] pull health tag should reflect Active or Halted state rather than Healthy (completed)

0xean avatar May 06 '24 22:05 0xean

@shapeshift/product

What I did on LP:

image image

If it's something else than Available, it will display Halted with a red tag

I also added the fact that we display every pools we support even if the status is halted, here is a monkey patched example:

image

It actually doesn't change anything and will almost never be shown as loan_collateral will mostly be 0, we actually end up with BTC and ETH pool for now but it works!

Pools: We already handle the status: image

BorrowInput: we already handle the slippage Acknowledge warning RepayInput: Missing the slippage acknowledge warning, I'll add it in the same PR

Do I miss anything regarding heuristics? Is that enough?

NeOMakinG avatar Jun 19 '24 22:06 NeOMakinG

Sounds right. It's that tag, e.g., if a lending pool is at capacity it shouldn't show as healthy.

It should say active probably.

Screenshot 2024-06-19 at 3 42 00 PM

twblack88 avatar Jun 19 '24 22:06 twblack88

  • We have acknowledgement almost everywhere except in RepayInput
  • Status are reflecting the real status of Lendings

If someone has a loan to repay or can deposit in the LP at one time because it's a bit emptier, feel free to finish this but it's pretty hard to test on my side for now

NeOMakinG avatar Jun 25 '24 15:06 NeOMakinG

potentially closing based on upcoming TC vote

0xean avatar Aug 26 '24 22:08 0xean