web icon indicating copy to clipboard operation
web copied to clipboard

Thorchain lending - enforce minOut

Open 0xean opened this issue 1 year ago • 1 comments

For TC lending:

  • create logic to add minOut to the memo
  • add x% slippage from expected output
  • validate transaction function correctly
  • uncomment minOut enforcement in memo.ts and enable tests

0xean avatar May 06 '24 21:05 0xean

waiting on PR to be tested when borrows are re-enabled.

0xean avatar May 13 '24 21:05 0xean

@0xean closing this one in favor of a loan open specific one: https://github.com/shapeshift/web/issues/6954 All other places now have MinOut enforced.

gomesalexandre avatar May 21 '24 08:05 gomesalexandre