web icon indicating copy to clipboard operation
web copied to clipboard

Lending Affiliate Fees

Open twblack88 opened this issue 1 year ago • 2 comments

Separating this out from Pull requests for better tracking. From PR #5813 ; uncluttering #6679

Upstream blockers

  • [x] https://gitlab.com/thorchain/thornode/-/merge_requests/3425
  • [x] DFC vote on params

DFC vote held quorum https://discord.com/channels/554694662431178782/920449863408287855/1225575197776543754

Lending fee parameters fox_max_discount_threshold= 300_000 no_fee_threshold_usd = 1_000 max_fee_bps = 69 // :nice: min_fee_bps = 10 FOX midpoint_usd = 150_000 steepness = 40_000

AC

  • add fee curve to lending memos
  • add fees to UI
  • unable to test for now due to lending caps.

twblack88 avatar Apr 17 '24 23:04 twblack88

https://gitlab.com/thorchain/thornode/-/merge_requests/3425

aaaand we're merged. LFG

twblack88 avatar May 13 '24 18:05 twblack88

PR #5813 - addresses this, blocked by testing since lending caps are in place.

0xean avatar May 13 '24 21:05 0xean

caps never removed. 😭

twblack88 avatar Sep 17 '24 17:09 twblack88