web icon indicating copy to clipboard operation
web copied to clipboard

Published 20 hours ago • verified publisher icon shapeshift

THORChain Lending - Approval step

Open gomesalexandre opened this issue 10 months ago • 2 comments

Overview

See https://github.com/shapeshift/web/pull/6676 - token repayments weren't implemented and have been wired up in that PR, but we need to check for allowance/add an approval step

Note this is an immediate "fix the bug and make this work" fix, and is to be directly follow-up on top of this stack with approvals handling - this will not work in and by itself without calling approve() first

References and additional details

N/A

Acceptance Criteria

  • Approvals needed are handled for lending borrows (even though THOR doesn't support token borrows yet) i.e check allowance and approve first before continuing if needed
  • Approvals needed are handled for lending repayments i.e check allowance and approve first before continuing if needed

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

gomesalexandre avatar Apr 12 '24 15:04 gomesalexandre

closing as stale.

0xean avatar May 13 '24 21:05 0xean

Still standing for borrows - to be added as a PR stacked on top of https://github.com/shapeshift/web/pull/6753

gomesalexandre avatar May 13 '24 21:05 gomesalexandre

closing - lending goes bye.

0xean avatar Oct 07 '24 22:10 0xean