web icon indicating copy to clipboard operation
web copied to clipboard

Add Account - Rabby-like selection screen (for Ledger only)

Open gomesalexandre opened this issue 10 months ago • 0 comments

Overview

We want to add a Rabby/MM-like selection screen when connecting Ledger accounts.

Note, this is blocked by https://github.com/shapeshift/web/issues/6672 and should be tackled as the last issue of Ledger/Add Account

References and additional details

None - this is a new screen

Acceptance Criteria

This ACC may be subject to change and should be a living document as the work on this feature is ongoing, to find the best compromise between being performant and not overfetching. In other words, the whole "do not fetch from unchained and upsert while selecting" may not be a thing in the final version of this.

  • For EVM chains accounts selection, the fiat balances over all EVM chains we support is displayed under each address in a way that's not a performance bottleneck (e.g by using Zapper balances endpoint)
  • For other chains, we display the value of each address in fiat as well
  • We have a Rabby-like accounts pick screen with an initial chunk of 5 accounts for said chain
  • Note, when adding Ethereum (EVM accounts), we should probably improve the copy of the Ledger screen to say this will add accounts over all EVM chains
  • We add the "Select Accounts" step to the new Ledger design/flow
  • As a user, I can select/unselect accounts as I wish, without them being added/removed from the redux store
  • I can "Load More" to load another chunk of 5
  • Only after clicking Confirm, the selection is upserted in the store

Need By Date

No response

Screenshots/Mockups

https://www.figma.com/proto/VEKmwSuhnZVghkUl0VSvN2/Ledger-UX?node-id=612-980&starting-point-node-id=612:980&locale=en

image image

Estimated effort

<= 1 day

gomesalexandre avatar Apr 11 '24 14:04 gomesalexandre