web icon indicating copy to clipboard operation
web copied to clipboard

Add Account - Should group accounts addition of EVM accounts

Open gomesalexandre opened this issue 10 months ago • 0 comments

Overview

Currently it is possible to add acounts for each chain, separately:

image

In contrast, Ledger adds all for EVM chains (note, Ethereum really refers to EVM chains here):

image

We want the "Add Account" button to act similar to the add EVM accounts for Ledger, adding all accounts for the specified account number.

Note, this issue is blocked by https://github.com/shapeshift/web/issues/6672 and assume we have removed the auto-not-so-magical account numbers discovery and should be tackled after, so that we don't end up in a scenario with the current automagical discovery, where we try to add e.g account 3 for all, but some EVM chains already have accounts 0-5, some have 0, some have 0-1 etc

References and additional details

https://github.com/shapeshift/web/blob/develop/src/pages/Accounts/AddAccountModal.tsx

Acceptance Criteria

  • All EVM accounts are now living under an "Ethereum (+ x more, where x is the amount of other EVM chains we support)" option
  • Adding "EVM accounts" adds all EVM accounts for said account number
  • The copy is reflected in the Ledger chains connection screen as well, which is doing the same

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

3 hours

gomesalexandre avatar Apr 11 '24 14:04 gomesalexandre