web icon indicating copy to clipboard operation
web copied to clipboard

Add Account - Remove previous Tx history limitations

Open gomesalexandre opened this issue 10 months ago • 0 comments

Overview

This issue is isolated to the "Add Account" feature only and is not related to the automagical accounts discovery.

Currently, we have some auto-"magical" accounts number discovery, which stops fetching when the current account has no Tx history.

That's one thing to use this as heuristics for discovery, but the issue here is the limitation is also here for manual "Add Account" functionality, without any rationale to limit users to do so.

References and additional details

Original isAbleToAddAccount implementation in #2702: https://github.com/shapeshift/web/pull/2702/files#diff-68fa73b2eac2fc2d43c7e89f845090ff6f7e55830383e855b59502c227702d9bR82

And matching selector: https://github.com/shapeshift/web/blob/d3f42415bbc6cfb41fe8fb0425b741e04709bac6/src/state/slices/txHistorySlice/selectors.ts#L201-L208

Acceptance Criteria

  • The previous Tx history limitation is removed from the "Add Account" functionality
  • The automagical discovery isn't affected and still works the same way as before

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

1 hour

gomesalexandre avatar Apr 11 '24 12:04 gomesalexandre