web icon indicating copy to clipboard operation
web copied to clipboard
verified publisher icon shapeshift

[Feature] Thorchain LP Support

Open 0xean opened this issue 2 years ago • 1 comments

Overview

This ticket is meant to the parent to aggregate tasks related to full thorchain LP Support in the app.

Full Spec

https://www.notion.so/shapeshift/ThorChain-LP-Full-Spec-12f27d28ec6d41d181610ee867f06b75 <- note this is a WIP and while the UI and spec will continue to evolve, we can get started on some of the core functionality we know we will need.

Figma

https://www.figma.com/file/hq8z2S8QwL2DciuGR8b0GR/Thorchain-LPs?type=design&node-id=740%3A467&mode=design&t=d3FZVfDYp3aTIZiF-1

Tickets

  • [x] https://github.com/shapeshift/web/issues/5939
  • [x] https://github.com/shapeshift/web/issues/5957
  • [x] https://github.com/shapeshift/web/issues/5958
  • [x] https://github.com/shapeshift/web/issues/5959
  • [x] https://github.com/shapeshift/web/issues/5967
  • [x] https://github.com/shapeshift/web/issues/6020
  • [x] https://github.com/shapeshift/web/issues/6021
  • [x] https://github.com/shapeshift/web/issues/5960
  • [x] https://github.com/shapeshift/web/issues/5968
  • [x] https://github.com/shapeshift/web/issues/6019
  • [x] https://github.com/shapeshift/web/issues/6021
  • [ ] https://github.com/shapeshift/web/issues/6022
  • [ ] Simulator for changes to LP positions
  • [x] https://github.com/shapeshift/web/issues/6091
  • [x] https://github.com/shapeshift/web/issues/6093
  • [x] https://github.com/shapeshift/web/issues/6094
  • [x] https://github.com/shapeshift/web/issues/6095
  • [x] https://github.com/shapeshift/web/issues/6096

Useful Links

  • LP Maths
    • https://github.com/xchainjs/xchainjs-lib/blob/master/packages/xchain-thorchain-query/src/utils/liquidity.ts
    • https://github.com/thorswap/SwapKit/blob/develop/packages/swapkit/helpers/src/helpers/liquidity.ts
    • https://gitlab.com/thorchain/thornode/-/issues/657
  • LP Calc
  • Midgard
  • LP position lookup quickstart
  • Examples (these might be a bit stale)
    • Add Liquidity
    • Remove
    • https://github.com/xchainjs/xchainjs-lib/blob/ade387b59d8fb2bbb86ef875200764c808d0426f/packages/xchain-thorchain-query/src/thorchain-query.ts#L317

0xean avatar Jan 03 '24 19:01 0xean

Last thing is of course mixpanel @gomesalexandre @0xApotheosis

twblack88 avatar Mar 13 '24 23:03 twblack88

Closing for now, will circle back on priority of simulator when TC LP TVL > 2million

0xean avatar Apr 15 '24 21:04 0xean