web icon indicating copy to clipboard operation
web copied to clipboard

feat: tx history assets transfers columns

Open gomesalexandre opened this issue 2 years ago • 1 comments

Description

This PR brings support for multiple inbound / outbound assets transfers as a <transfersAmount> transfers column in Tx history.

Notice

  • [x] Have you followed the guidelines in our Contributing guide?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • [ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
  • [ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • [x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes https://github.com/shapeshift/web/issues/2428

Risk

We could wrongly parse Txs with a single transfer in/out as a many transfers Tx (see screenshot), and vice versa, which would indicate issues with unchained-client parsing

Testing

  • Txs with a single inbound/outbound asset transfer should still be parsed as before
  • Txs with multiple assets' transfers either inbound or outbound, should show <x assets> where x is the number of assets in the transfer type (send/receive), and the total fiat amount for said assets' value

Engineering

  • Implementation looks sane

Operations

Screenshots (if applicable)

image image

gomesalexandre avatar Oct 22 '22 16:10 gomesalexandre

Current dependencies on/for this PR:

  • develop
    • PR #3133 Graphite
      • PR #3135 Graphite
        • PR #3134 Graphite 👈
          • PR #3138 Graphite

This comment was auto-generated by Graphite.

gomesalexandre avatar Oct 22 '22 16:10 gomesalexandre