web
web copied to clipboard
shapeshift
MAX trades for BCH and DOGE giving "Not enough ETH to cover gas" error message
Overview
When creating a BCH or DOGE trade, if you select the MAX amount, it gives the "Not enough ETH to cover gas" error message.
References and additional details
- Log into release.shapeshift.com and connect to native (Ensure Thorchain flag is on)
- In the trade widget or on the Trade page create a BCH or DOGE trade and select the MAX button
- Notice the "Not enough ETH to cover gas" error message
Acceptance Criteria
The MAX amount for the send should not give error
Need By Date
No response
Screenshots/Mockups
No response
Ownership
- [X] If my bounty needs engineering or needs product I have added the respective labels on the right
- [X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)
Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters
- Join our discord
- Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
- Please refer to this link for some basic info
- Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria I cannot reproduce in latest develop, can you confirm this is fixed in develop.shapeshift.com and/or the next release we cut? 🙏🏽
https://user-images.githubusercontent.com/17035424/193829677-4c53f310-c339-423f-a208-fe3c2ea23a2c.mov
@gomesalexandre currently testing Release 1.00.0 and still getting the error
@0xdef1cafe, @MBMaria and I are still able to recreate this issue when max selling out of DOGE and BCH.
Testing Release: https://github.com/shapeshift/web/pull/3096 and getting the not enough ETH for gas error when selecting max DOGE (and not having enough doge to complete the trade)
closed in 1.131.0 as per https://discord.com/channels/554694662431178782/1037839526086848522/1037853717329887332
