shapeshift
fix: show total crypto value with fees
Description
Show total crypto value with fees in Confirm summary
Notice
- [x] Have you followed the guidelines in our Contributing guide?
- [ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Pull Request Type
- [x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
- [ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
- [ ] :nail_care: New Feature (Breaking/Non-breaking Change)
Issue (if applicable)
closes #
Risk
Low - math should add up
Testing
Verify Total crypto value on Confirm summary displays the correct amount (cryptoAmount + fee)
Engineering
see above
Operations
see above
Screenshots (if applicable)
CosmosSDK Modal
Before
After
Common Modal
Before
After
@shapeshift/product can you confirm this is the desired behavior. It seemed incorrect to have the crypto amount shown at the top and then the same crypto amount shown for the total when the corresponding fiat value includes the fee.
@shapeshift/product can you confirm this is the desired behavior. It seemed incorrect to have the crypto amount shown at the top and then the same crypto amount shown for the total when the corresponding fiat value includes the fee.
@kaladinlight I think you are right, let's remove the crypto amount there and just display the fiat amount.
Total (Amount + Transaction Fee) ----- $76.47
@shapeshift/product can you confirm this is the desired behavior. It seemed incorrect to have the crypto amount shown at the top and then the same crypto amount shown for the total when the corresponding fiat value includes the fee.
@kaladinlight I think you are right, let's remove the crypto amount there and just display the fiat amount.
Total (Amount + Transaction Fee) ----- $76.47
Are you suggesting we remove the Total ---- 1337.000647 row all together? I still feel like the total crypto with fees would be useful to display alongside the fiat total with fees
@shapeshift/product can you confirm this is the desired behavior. It seemed incorrect to have the crypto amount shown at the top and then the same crypto amount shown for the total when the corresponding fiat value includes the fee.
@kaladinlight I think you are right, let's remove the crypto amount there and just display the fiat amount. Total (Amount + Transaction Fee) ----- $76.47
Are you suggesting we remove the Total ---- 1337.000647 row all together? I still feel like the total crypto with fees would be useful to display alongside the fiat total with fees
The user can see these amounts from the above rows right? The gas cost, the total amount of crypto they are sending.
That bottom row is just showing them total cost of all the things above. I'm not sure we have a good way to show the user the token amount + ETH amount in a clean way.
@shapeshift/product can you confirm this is the desired behavior. It seemed incorrect to have the crypto amount shown at the top and then the same crypto amount shown for the total when the corresponding fiat value includes the fee.
@kaladinlight I think you are right, let's remove the crypto amount there and just display the fiat amount. Total (Amount + Transaction Fee) ----- $76.47
Are you suggesting we remove the Total ---- 1337.000647 row all together? I still feel like the total crypto with fees would be useful to display alongside the fiat total with fees
The user can see these amounts from the above rows right? The gas cost, the total amount of crypto they are sending.
That bottom row is just showing them total cost of all the things above. I'm not sure we have a good way to show the user the token amount + ETH amount in a clean way.
The above rows do show and you are totally right and probably why it was set up in the way it was because of eth as the fee asset when sending a token. So that update I have is actually incorrect for eth, though it happens to work out for the cosmos based coins. If you think just the total fiat value is sufficient that would certainly remove any of the confusion. I can update accordingly if that is the route we wish to go:
Crypto Value Transaction Fee Breakdown Amount + Transaction Fee Fiat value
@shapeshift/product can you confirm this is the desired behavior. It seemed incorrect to have the crypto amount shown at the top and then the same crypto amount shown for the total when the corresponding fiat value includes the fee.
@kaladinlight I think you are right, let's remove the crypto amount there and just display the fiat amount. Total (Amount + Transaction Fee) ----- $76.47
Are you suggesting we remove the Total ---- 1337.000647 row all together? I still feel like the total crypto with fees would be useful to display alongside the fiat total with fees
The user can see these amounts from the above rows right? The gas cost, the total amount of crypto they are sending. That bottom row is just showing them total cost of all the things above. I'm not sure we have a good way to show the user the token amount + ETH amount in a clean way.
The above rows do show and you are totally right and probably why it was set up in the way it was because of eth as the fee asset when sending a token. So that update I have is actually incorrect for eth, though it happens to work out for the cosmos based coins. If you think just the total fiat value is sufficient that would certainly remove any of the confusion. I can update accordingly if that is the route we wish to go:
Crypto Value Transaction Fee Breakdown Amount + Transaction Fee Fiat value
Yah I think for right now just showing the fiat total will make it easier to understand. And we can circle back later --- once we figure out a elegant way to display both in a NON confusing way.
@shapeshift/product can you confirm this is the desired behavior. It seemed incorrect to have the crypto amount shown at the top and then the same crypto amount shown for the total when the corresponding fiat value includes the fee.
@kaladinlight I think you are right, let's remove the crypto amount there and just display the fiat amount. Total (Amount + Transaction Fee) ----- $76.47
Are you suggesting we remove the Total ---- 1337.000647 row all together? I still feel like the total crypto with fees would be useful to display alongside the fiat total with fees
The user can see these amounts from the above rows right? The gas cost, the total amount of crypto they are sending. That bottom row is just showing them total cost of all the things above. I'm not sure we have a good way to show the user the token amount + ETH amount in a clean way.
The above rows do show and you are totally right and probably why it was set up in the way it was because of eth as the fee asset when sending a token. So that update I have is actually incorrect for eth, though it happens to work out for the cosmos based coins. If you think just the total fiat value is sufficient that would certainly remove any of the confusion. I can update accordingly if that is the route we wish to go: Crypto Value Transaction Fee Breakdown Amount + Transaction Fee Fiat value
Yah I think for right now just showing the fiat total will make it easier to understand. And we can circle back later --- once we figure out a elegant way to display both in a NON confusing way.
@kaladinlight yah if we go this route and just show the total fiat amount on the bottom, can we add the precision to the top amount, we may need to reduce the font size a little to fit it all. But for example above:
1,337 FOX would become 1,337.000647 FOX
kickin to draft until implemented per https://discord.com/channels/554694662431178782/1019691103487803484/1019720589021302805
