web icon indicating copy to clipboard operation
web copied to clipboard

feat: add @shapeshiftoss/logger/no-native-console rule

Open gomesalexandre opened this issue 3 years ago • 1 comments

Description

Removes the previously enforced no-console rule, and uses our @shapeshiftoss/logger/no-console rule instead.

Blocked by https://github.com/shapeshift/lib/pull/983

Notice

  • [ ] Have you followed the guidelines in our Contributing guide?
  • [ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • [ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
  • [ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • [ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #

Risk

Testing

Engineering

Operations

Screenshots (if applicable)

gomesalexandre avatar Aug 26 '22 15:08 gomesalexandre

Current dependencies on/for this PR:

  • develop
    • PR #2453 Graphite
      • PR #2448 Graphite
        • PR #2574 Graphite 👈

This comment was auto-generated by Graphite.

gomesalexandre avatar Aug 26 '22 15:08 gomesalexandre

TODO once package is published:

-"@shapeshiftoss/eslint-plugin-logger": "../shapeshiftLib/packages/eslint-plugin-logger",
+"@shapeshiftoss/eslint-plugin-logger": "^1.0.0",

0xApotheosis avatar Sep 13 '22 00:09 0xApotheosis