web icon indicating copy to clipboard operation
web copied to clipboard

fix: redirect keepkey users if they accidentally exit the wipe modal

Open jmurphy5613 opened this issue 3 years ago • 7 comments

…cess

Description

I added a check in WalletViewsSwitch.tsx that redirects Keeykey users to the main page if they exit the modal. Instead of the app being in a broken state where it appears that they are connected with a keepkey, they can re-enter the connect wallet process.

This does not redirect users after a successful wipe setup.

Notice

  • [x] Have you followed the guidelines in our Contributing guide?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • [x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
  • [ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • [ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

fixes #1610

Risk

None

Testing

Connect a wiped Keepkey, and enter the connect wallet flow. Then try to close the modal during the set up process.

Screenshots (if applicable)

jmurphy5613 avatar Aug 17 '22 19:08 jmurphy5613

Hi @jmurphy5613.

Thanks for your contribution, however for bounties we only accept contributions once you've been approved for the task: https://app.dework.xyz/shapeshift-dao/keepkey-bounties?taskId=1546ffaa-5a94-4409-8546-d6e892e8cd90

0xApotheosis avatar Aug 18 '22 00:08 0xApotheosis

Hi @jmurphy5613.

Thanks for your contribution, however for bounties we only accept contributions once you've been approved for the task: https://app.dework.xyz/shapeshift-dao/keepkey-bounties?taskId=1546ffaa-5a94-4409-8546-d6e892e8cd90

I am approved for this task. I think you may be looking at the bounty.

jmurphy5613 avatar Aug 18 '22 00:08 jmurphy5613

*updated the dwork. This is a @Cosmic on discord https://app.dework.xyz/shapeshift-dao/keepkey-bounties/overview?taskId=85103378-5099-4435-a609-0cd3540ad601

BitHighlander avatar Aug 18 '22 00:08 BitHighlander

*updated the dwork. This is a @cosmic on discord https://app.dework.xyz/shapeshift-dao/keepkey-bounties/overview?taskId=85103378-5099-4435-a609-0cd3540ad601

Got it, ty @BitHighlander - re-opening.

0xApotheosis avatar Aug 18 '22 05:08 0xApotheosis

@jmurphy5613 do you own a keepkey?

0xdef1cafe avatar Aug 23 '22 17:08 0xdef1cafe

@jmurphy5613 do you own a keepkey?

yep

jmurphy5613 avatar Aug 23 '22 18:08 jmurphy5613

converting to draft. please fix lint errors and run yarn local-ci on your machine and fix all issues before pushing.

0xdef1cafe avatar Aug 24 '22 16:08 0xdef1cafe