web
web copied to clipboard
FOX-ETH LP Icon Fix
Overview
When depositing FOX and ETH in to the FOX-ETH LP, transactions only show the ETH icon when you are depositing and the FOX icon when you are withdrawing. Transactions should show both icons as you are withdrawing and depositing ETH and FOX into the LP simultaneously.
References and additional details
- log into app.shapeshift
- go the the DeFi earn page
- click on the FOX-ETH v2 LP
- do a deposit and withdraw
- go to you transaction history page or the recent transactions on the dashboard
- notice it only shows the ETH icon for deposits and the FOX iron for withdraws
Acceptance Criteria
Transactions should show both icons as you are withdrawing and depositing ETH and FOX into the LP simultaneously.
Need By Date
No response
Screenshots/Mockups
Deposit:
Withdraw:
How the icon should look for both deposits and withdraws:
Estimated effort
No response
We worked on a mock on how we could do this, and allow this to scale when we allow more than 2 sided pools.
Related to https://github.com/shapeshift/web/issues/2345 There will be unchained-client Tx Metadata parsing needed here, which is the same thing we need in the aforementioned issue