web icon indicating copy to clipboard operation
web copied to clipboard

FOX-ETH LP Icon Fix

Open wesleygravess opened this issue 2 years ago • 2 comments

Overview

When depositing FOX and ETH in to the FOX-ETH LP, transactions only show the ETH icon when you are depositing and the FOX icon when you are withdrawing. Transactions should show both icons as you are withdrawing and depositing ETH and FOX into the LP simultaneously.

References and additional details

  1. log into app.shapeshift
  2. go the the DeFi earn page
  3. click on the FOX-ETH v2 LP
  4. do a deposit and withdraw
  5. go to you transaction history page or the recent transactions on the dashboard
  6. notice it only shows the ETH icon for deposits and the FOX iron for withdraws

Acceptance Criteria

Transactions should show both icons as you are withdrawing and depositing ETH and FOX into the LP simultaneously.

Need By Date

No response

Screenshots/Mockups

Deposit: Screenshot 2022-08-12 154806

Withdraw: Screenshot 2022-08-12 154823

How the icon should look for both deposits and withdraws: Screenshot 2022-08-12 154912

Estimated effort

No response

wesleygravess avatar Aug 12 '22 19:08 wesleygravess

We worked on a mock on how we could do this, and allow this to scale when we allow more than 2 sided pools.

Screen Shot 2022-08-15 at 11 00 45 AM

reallybeard avatar Aug 15 '22 15:08 reallybeard

Related to https://github.com/shapeshift/web/issues/2345 There will be unchained-client Tx Metadata parsing needed here, which is the same thing we need in the aforementioned issue

gomesalexandre avatar Aug 17 '22 18:08 gomesalexandre