web icon indicating copy to clipboard operation
web copied to clipboard

Published 20 hours ago • verified publisher icon shapeshift

Improve PIN modal

Open 0xApotheosis opened this issue 2 years ago • 4 comments

Overview

There are a number of quirks with the PIN modal that we can improve.

165401810-5e4d9cad-408c-4804-975a-8fbfa2befae6

References and additional details

From @mrnerdhair:

  1. This screen should focus the entry field to allow the PIN to be entered using only the numpad keys, which map to the KK's on-screen PIN layout.
  2. Pressing the "Enter" key should have the same effect as pressing the confirm key.
  3. Confirming the new PIN on the first screen and loading the second one briefly flashes "Unlock" instead of "Save PIN" on the button
  4. If you exit after the first PIN screen, restarting the flow will hang unless you replug your device.
  5. Pressing "Confirm" without any numbers entered greys out the button and prevents further progress. The PIN screen is also still displayed on device even after pressing the back button, breaking the previous flows. (Setting a PIN is technically optional during initialization, so trying a blank one could be a valid choice. Still, with my security hat on I'm happy to hide that from users. If we're going to do that, though, we should disable the button if it's blank.)

Acceptance Criteria

All of the above improvements are implemented.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

0xApotheosis avatar Apr 28 '22 03:04 0xApotheosis

@pastaghost is AC#4 possible to replicate without a KK?

GMSteuart avatar Jul 18 '22 19:07 GMSteuart

@GMSteuart No, this will require a KeepKey to replicate. As of today, this issue along with #1610 and #1607 have been assigned to @brymut via DeWork.

pastaghost avatar Jul 18 '22 20:07 pastaghost

PASSWORD

fiyanrendiant avatar Aug 23 '22 10:08 fiyanrendiant

PASSWORD

Sir?

0xApotheosis avatar Aug 25 '22 09:08 0xApotheosis

Yes

Pada tanggal Kam, 25 Agu 2022 16.31, Apotheosis @.***> menulis:

PASSWORD

Sir?

— Reply to this email directly, view it on GitHub https://github.com/shapeshift/web/issues/1613#issuecomment-1227018004, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2VPKGZGGARF4SEC4DS3N6LV244QNANCNFSM5UQ62JMA . You are receiving this because you commented.Message ID: @.***>

fiyanrendiant avatar Sep 07 '22 07:09 fiyanrendiant

Thank you!

Pada tanggal Sen, 12 Sep 2022 14.16, Apotheosis @.***> menulis:

Closed #1613 https://github.com/shapeshift/web/issues/1613 as completed via #2689 https://github.com/shapeshift/web/pull/2689.

— Reply to this email directly, view it on GitHub https://github.com/shapeshift/web/issues/1613#event-7364685797, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2VPKGZOSB4MOXKKBDH5HXLV53KEXANCNFSM5UQ62JMA . You are receiving this because you commented.Message ID: @.***>

fiyanrendiant avatar Sep 12 '22 16:09 fiyanrendiant