web icon indicating copy to clipboard operation
web copied to clipboard

Move KeepKey PIN entry when changing device PIN to settings menu

Open 0xApotheosis opened this issue 3 years ago • 2 comments

We initially bootstrapped the existing PIN entry modals, but when changing the PIN via the menu the entry should happen inside the menu itself.

UI: https://www.sketch.com/s/5e6ddd00-6f97-47f5-8daa-6e20a967f4b0/p/7E2E52BC-86BF-42B9-AC2E-8864E8D32111 Spec: https://shapeshift.notion.site/KeepKey-Settings-86cce69e059346c0b14aa0547703465a

0xApotheosis avatar Apr 07 '22 03:04 0xApotheosis

@pastaghost how much did you want to put on this bounty?

MBMaria avatar Jul 20 '22 21:07 MBMaria

As I said to @0xApotheosis in private, I feel kind of stuck now

Everything works as expected but I have a strange behavior when canceling a KeepKey action:

If you go back or cancel when it asks the new pin, the KeepKey will ask for the passphrase and it won't be possible to push the physical button, it's frozen.

NeOMakinG avatar Aug 31 '22 15:08 NeOMakinG