lib icon indicating copy to clipboard operation
lib copied to clipboard

Stop unit tests making network requests

Open 0xdef1cafe opened this issue 3 years ago • 5 comments

Overview

Unit tests are making network requests - failing tests below for reference

References and additional details

  • https://github.com/shapeshift/lib/runs/6780526107?check_suite_focus=true

Acceptance Criteria

  • Fix the root cause and prevent unit tests from making network requests
  • Bonus points - stop tests logging from console to prevent spew

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

4 hours

0xdef1cafe avatar Jun 07 '22 19:06 0xdef1cafe

still valid but low priority

0xdef1cafe avatar Jul 20 '22 19:07 0xdef1cafe

@0xdef1cafe we have had a bounty hunter request to work on this as a bounty. Thoughts? https://app.dework.xyz/shapeshift-dao/shapeshift-bounties?taskId=50285c4b-e87f-4693-a63a-3cad768f1179

MBMaria avatar Aug 02 '22 01:08 MBMaria

@0xf11nix you keen for this buddy? low priority and no deadline

0xdef1cafe avatar Aug 03 '22 19:08 0xdef1cafe

@0xf11nix you keen for this buddy? low priority and no deadline

@0xdef1cafe Yeah mate, I've got this one. Should be able to smash most of it out over the weekend, if that suits?

0xf11nix avatar Aug 04 '22 11:08 0xf11nix

Hi @0xdef1cafe, might this still be relevant/available?

brymut avatar Oct 26 '22 06:10 brymut