lib icon indicating copy to clipboard operation
lib copied to clipboard

Remove patch from lib

Open 0xdef1cafe opened this issue 4 years ago • 6 comments

https://github.com/shapeshift/lib/pull/136/files#diff-c3f51ca8777f4cc6e6128ef417f7c38d87662e7413cd8471dfc9237b5685beb4R1-R17

this is not production ready and isn't the solution. we need to fork this repo and fix it.

0xdef1cafe avatar Oct 19 '21 23:10 0xdef1cafe

@reidrankin - Can you please create a ticket in HD wallet to remove all bithighlander dependencies?

0xean avatar Dec 10 '21 22:12 0xean

Huh, I thought this was taken care of already. Looks like tendermint-tx-builder still has a transitive dep on an old version of his bitcoinjs fork, though. We'll need to fork that and update it.

mrnerdhair avatar Dec 10 '21 22:12 mrnerdhair

assigned to @BitHighlander

0xean avatar Jan 28 '22 22:01 0xean

this will be addressed by the new https://github.com/shapeshift/tendermint-tx-builder repo

0xdef1cafe avatar Feb 09 '22 18:02 0xdef1cafe

Blocked by shapeshift/hdwallet#409.

mrnerdhair avatar Mar 21 '22 01:03 mrnerdhair

@mrnerdhair - can you comment on if this ticket is still valid?

0xean avatar Jun 15 '22 20:06 0xean