hdwallet icon indicating copy to clipboard operation
hdwallet copied to clipboard

feat: make the bnb sdk an optionalDependency

Open mrnerdhair opened this issue 3 years ago • 1 comments

  • We don't use BNB support in shapeshift/web at the moment, and having to ship a heavy SDK we don't use is silly
  • The old bnb-javascript-sdk-nobroadcast is very stale and isn't maintained under the org (I made @shapeshiftoss/bnb-javascript-sdk to fix that, it's got CI and everything)
  • The BNB SDK version includes various transitive dependencies which produce npm audit warnings. None of these are applicable to our specific use of it, but providing a way for other devs not to have to depend on this package -- and therefore get bugged by their users -- would be a nice-to-have, especially if they only want e.g. Ethereum support in the first place.

mrnerdhair avatar Jun 09 '22 00:06 mrnerdhair

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hdwallet ✅ Ready (Inspect) Visit Preview Jun 9, 2022 at 7:02AM (UTC)

vercel[bot] avatar Jun 09 '22 00:06 vercel[bot]

closing as stale.

0xean avatar Jan 29 '24 21:01 0xean