fix: updated intanceof checks to allow Buffer intances
Due to polyfill of Buffer on webv2, the function fromB64ToArray was returning type Buffer, instead of Uint8Array. This was causing an error to be thrown and blocking decryption of a wallet.
This PR updates the checks to allow instanceof Buffer in addition to the existing ArrayBuffer and Uint8Array types.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| hdwallet | ✅ Ready (Inspect) | Visit Preview | Jul 23, 2022 at 0:46AM (UTC) |
Double-checking; is this issue still relevant / can we close this?
It seems to me that Buffer is a valid input to those functions, seeing as how no code changes were needed to support Buffer. I don't see a downside here.
closing as stale.