tartelet
tartelet copied to clipboard
shapehq
Enterprise hosting support
Add the ability to specify an GitHub Enterprise Server URL so that users can use custom instances of self-hosted GitHub. The runner type enterprise is added so enterprises hosted on GitHub Cloud can add runners to the whole enterprise
Fixes #27
This PR is very much a WIP, there are a bunch of things to do before it is ready (code cleanup, duplication, etc.) but we need to verify that it is working before all and at the moment I don't have any ability to do it. Let's hope the community can share some feedback
@mattia Thanks a lot for opening this PR! I think it would be great to have this functionality in Tartelet. I'll make sure to review it once I have the time 😊
Any update?
Hi @hoon-prestolabs! Unfortunately I don't have any news regarding this. The basic functionality is implemented and should work fine but I'm leaving the PR in draft because I don't want to propose this change without a feedback from users with this configuration. If you are using GitHub Enterprise Server your feedback on this change would be welcome!
Hm i tried out the pr branch and at first it seemed to work well however when starting against a github enterprise server i got following error which i could not trace town yet:
Request to my-ghes-server.com/app/installations failed: unsupported URL
Hm i tried out the pr branch and at first it seemed to work well however when starting against a github enterprise server i got following error which i could not trace town yet:
Request to my-ghes-server.com/app/installations failed: unsupported URL
Hi! This branch was a crude attempt, given that I didn't have (and still don't have) access to a GitHub Enterprise server to test against.
The only piece of advice I can give you is to check the enterprise server URL, it should be a valid Swift URL ( eg. https://my-ghes-server.com) and not only the host.
Given that the community didn't show interested in this feature and that the main branch has made progress I'm not inclined to try to rebase and fix all merge conflicts. I will wait a bit for feedback but unless a lot of people chime in and provide support for this I will close PR
Hm i tried out the pr branch and at first it seemed to work well however when starting against a github enterprise server i got following error which i could not trace town yet:
Request to my-ghes-server.com/app/installations failed: unsupported URLHi! This branch was a crude attempt, given that I didn't have (and still don't have) access to a GitHub Enterprise server to test against. The only piece of advice I can give you is to check the enterprise server URL, it should be a valid Swift URL ( eg.
https://my-ghes-server.com) and not only the host.Given that the community didn't show interested in this feature and that the main branch has made progress I'm not inclined to try to rebase and fix all merge conflicts. I will wait a bit for feedback but unless a lot of people chime in and provide support for this I will close PR
Thanks for the hint indeed it seemed i was missing the protocol and in addition the api path so usually:
https://my-ghes-server.com/api/v3. However i hit other issues maybe due to the age of the version the PR is build on.
Since there was a lot of change rebasing is not that straigt forward. I will try out cilicon for now as they have an option to pass a different github api url too.