firsttimersonly icon indicating copy to clipboard operation
firsttimersonly copied to clipboard

Fix one of our spelling errors

Open shanselman opened this issue 9 years ago • 16 comments

shanselman avatar Aug 10 '15 18:08 shanselman

dvanbale referenced this issue from a commit on 13 Sep

Does this mean this issue should be closed?

savaii avatar Dec 02 '15 22:12 savaii

Nah, there's always spelling errors to fix! ;)

shanselman avatar Dec 06 '15 03:12 shanselman

This particular spelling issue is fixed, I'm sure there are more you can fix, but my pull request was never accepted.

dvanbale avatar Dec 06 '15 13:12 dvanbale

@dvanbale Sorry, was in my spam!

shanselman avatar Jul 14 '16 05:07 shanselman

Hi @shanselman I've noticed that there is no consistency on the page with capitalising the words 'Open Source'. There are the following variations in different places:

  • Open Source
  • open source
  • Open Source project
  • Open Source Project
  • OSS (Open Source Software) Project

I know this isn't a big deal, but it might be good to stick to one version. It's my opinion that it shouldn't be capitalised except when it is an acronym (OSS), but perhaps you'd prefer Open Source projects. Either way, I'd be happy to comb through the page and ensure consistency once you let me know what you'd prefer.

jacklorusso avatar Oct 24 '16 07:10 jacklorusso

Sure!

On Mon, Oct 24, 2016 at 12:46 AM, Jack Lo Russo [email protected] wrote:

Hi @shanselman https://github.com/shanselman I've noticed that there is no consistency on the page with capitalising the words 'Open Source'. There are the following variations in different places:

  • Open Source
  • open source
  • Open Source project
  • Open Source Project
  • OSS (Open Source Software) Project

I know this isn't a big deal, but it might be good to stick to one version. It's my opinion that it shouldn't be capitalised except when it is an acronym (OSS), but perhaps you'd prefer Open Source projects. Either way, I'd be happy to comb through the page and ensure consistency once you let me know what you'd prefer.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shanselman/firsttimersonly/issues/5#issuecomment-255670330, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALTMojoxqLhaFTwQGqQBQfF1Wlc4Hyks5q3GI9gaJpZM4Fo7SG .

Scott Hanselman Donate to fight diabetes: http://hnsl.mn/fightdiabetes

shanselman avatar Oct 25 '16 18:10 shanselman

Could i know why my PR was not merged?

ghost avatar Nov 12 '16 15:11 ghost

Sorry, we were off launching VS for Mac. I was travelling! I'll fix it.

On Sat, Nov 12, 2016 at 7:35 AM, Shreya Bhandare [email protected] wrote:

Could i know why my PR was not merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shanselman/firsttimersonly/issues/5#issuecomment-260128749, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALTJKh1lfB9lAhvb_lPLTC1-nGA3Fqks5q9dytgaJpZM4Fo7SG .

Scott Hanselman Donate to fight diabetes: http://hnsl.mn/fightdiabetes

shanselman avatar Nov 18 '16 19:11 shanselman

Hi @shanselman,

We recommend you follow @yourfirstpr and let them know if your OSS project has a firsttimers only tag and you have open issues that you’ll reserve for a new contributor!

It should be first-timers-only to make it consistent with other occurrences of this tag on the site. I'd be happy to make this change. It will be my first contribution on github.

ankitdwivedi23 avatar Jan 22 '17 06:01 ankitdwivedi23

Is any help still needed here ?

morrme avatar Mar 21 '17 03:03 morrme

Submitted pull request 41.

ghost avatar Mar 04 '18 14:03 ghost

Is there still any need for help with this issue?

lax0248917 avatar Aug 07 '20 12:08 lax0248917

I also noticed grammatical issues in the READme and some words that needs to be rephrased for proper communication. Do let me know if I can take that.

abideen305 avatar Sep 22 '20 03:09 abideen305

I have sent a PR fixing few of the errors.

musk101 avatar Oct 01 '20 19:10 musk101

Hi @shanselman , I have sent a pull request for modifying the ReadMe file to make it more friendly for the new contributors, I hope it adds value to the project.

DevanshiPatel18 avatar Oct 17 '20 11:10 DevanshiPatel18

Hello! Please assign me this issues

Gulnaz44 avatar Oct 22 '22 11:10 Gulnaz44